Skip to content

File conversion: Make sample rate optional #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

File conversion: Make sample rate optional #22

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2259c64
allow no sample rate params, to use file sample rate
Jul 26, 2025
4704074
sample rate
Jul 26, 2025
32483a4
cleanup
Jul 26, 2025
363b65a
PR changes
Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 48 additions & 44 deletions maestro_worker_python/convert_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ def __init__(self, message):
class FileToConvert:
input_file_path: str
file_format: str
output_file_path: str = None
output_file_path: str | None = None
max_duration: int = 1200
sample_rate: int = 44100
sample_rate: int | None = 44100


def convert_files(convert_files: List[FileToConvert]):
Expand Down Expand Up @@ -92,48 +92,52 @@ def convert_files_manager(*convert_files: FileToConvert) -> None | str | list[st
obj.close()


def _convert_to_wav(input_file_path, output_file_path, max_duration, sample_rate=44100):
_run_subprocess(
[
"ffmpeg",
"-y",
"-hide_banner",
"-loglevel",
"error",
"-t",
str(max_duration),
"-i",
str(input_file_path),
"-ar",
str(sample_rate),
str(output_file_path),
]
)


def _convert_to_m4a(input_file_path, output_file_path, max_duration, sample_rate=44100):
_run_subprocess(
[
"ffmpeg",
"-y",
"-hide_banner",
"-loglevel",
"error",
"-t",
str(max_duration),
"-i",
str(input_file_path),
"-c:a",
"aac",
"-b:a",
"192k",
"-ar",
str(sample_rate),
"-movflags",
"+faststart",
str(output_file_path),
]
)
def _convert_to_wav(input_file_path: str, output_file_path: str, max_duration: int, sample_rate: int | None = 44100):
command_list = [
"ffmpeg",
"-y",
"-hide_banner",
"-loglevel",
"error",
"-t",
str(max_duration),
"-i",
str(input_file_path),
]

if sample_rate is not None:
command_list.extend(["-ar", str(sample_rate)])

command_list.append(str(output_file_path))

_run_subprocess(command_list)


def _convert_to_m4a(input_file_path: str, output_file_path: str, max_duration: int, sample_rate: int | None = 44100):
command_list = [
"ffmpeg",
"-y",
"-hide_banner",
"-loglevel",
"error",
"-t",
str(max_duration),
"-i",
str(input_file_path),
"-c:a",
"aac",
"-b:a",
"192k",
"-movflags",
"+faststart",
]

if sample_rate is not None:
command_list.extend(["-ar", str(sample_rate)])

command_list.append(str(output_file_path))

_run_subprocess(command_list)


def _run_subprocess(command):
Expand Down