feat(db) Add func disable subscription for contact - #1287
Draft
kissken wants to merge 2 commits into
Draft
Conversation
Tetrergeru
reviewed
Jul 27, 2026
| } | ||
|
|
||
| // DisableSubscription make subscription disable or drop broken contact. | ||
| func (connector *DbConnector) DisableSubscription(subscriptionID, brokenContactID string) (bool, error) { |
Member
There was a problem hiding this comment.
Оч что-то мне не нравится, что мы автоматически отцепляем контакт от подписки. Мне кажется, что это может привести к условному сценарию
- Недоступен канал доставки
- Уведомления не доезжает
- Массовое открепление контактов от подписок
Может нам надо подумать в сторону того что бы именно контакт научиться отключать?
Member
Author
There was a problem hiding this comment.
как вариант, пока уметь только дизэйблить подписку если контакт один, а если их несколько пока не менять логику, мнениея?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
added func for disable subscription for contact