feat(checker) Move bad state reminder into config - #1242
Open
kissken wants to merge 6 commits into
Open
Conversation
kissken
commented
Nov 11, 2025
| realtime := urlValues.Get("realtime") | ||
| if realtime == "" { | ||
| return | ||
| return sourceProvider, targetName, from, to, triggerID, fetchRealtimeData, err |
Member
Author
There was a problem hiding this comment.
это линтер орал - полечила
HeavyPunk
reviewed
Nov 11, 2025
mchrome
previously approved these changes
Nov 11, 2025
Tetrergeru
reviewed
Nov 13, 2025
| CriticalTimeOfCheck: "1h", | ||
| MetricEventTriggerCheckInterval: "30s", | ||
| BadStateReminder: map[string]int64{ | ||
| moira.StateERROR.String(): moira.DefaultBadStateReminder, |
Member
There was a problem hiding this comment.
А у нас нет какого-то списка стейтов, которые считаются Bad? Чтобы не хардкодить, а по нему пробежаться
Member
Author
There was a problem hiding this comment.
ну вообще вот мы тут как раз его и создаем - это ж конфиг :)
Tetrergeru
reviewed
Nov 13, 2025
| } | ||
|
|
||
| remindInterval, ok := badStateReminder[currentStateValue] | ||
| remindInterval, ok := triggerChecker.badStateReminder[currentStateValue] |
Member
There was a problem hiding this comment.
Может добавить, что if !ok { remindInterval = moira.DefaultBadStateReminder }
Member
Author
There was a problem hiding this comment.
норм, но я не уверена, что это будет явно
# Conflicts: # .golangci.yml
mchrome
approved these changes
Nov 18, 2025
HeavyPunk
approved these changes
Nov 19, 2025
Member
Author
|
/build |
|
Build and push Docker images with tag: feat-add_reminder_into_config.2025-11-19.4cd024a |
1 similar comment
|
Build and push Docker images with tag: feat-add_reminder_into_config.2025-11-19.4cd024a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Move bad state reminder into config
Closes/Relates #issue