Fix UI text visibility and enhance color contrast#6
Open
RedWilly wants to merge 3 commits intomohyware:mainfrom
Open
Fix UI text visibility and enhance color contrast#6RedWilly wants to merge 3 commits intomohyware:mainfrom
RedWilly wants to merge 3 commits intomohyware:mainfrom
Conversation
|
@RedWilly is attempting to deploy a commit to the Mohy Elden's projects Team on Vercel. A member of the Team first needs to authorize it. |
mohyware
requested changes
May 25, 2025
Owner
mohyware
left a comment
There was a problem hiding this comment.
Thanks for the PR!
I've really wanted to make the colors in Tailwind more usable, so it’ll be easier if we ever add light mode or make any changes to the app theme.
Comment on lines
+23
to
+24
| 'surface-secondary': '#2a2a2a', | ||
| 'dark-surface-secondary': '#2a2a2a', |
Owner
| </div> | ||
| <Link href="https://github.com/mohyware/clip.js" target="_blank" | ||
| className="rounded-full bg-black border border-solid border-transparent transition-colors flex items-center justify-center bg-foreground text-background gap-2 hover:bg-[#383838] font-medium text-sm sm:text-base h-10 sm:h-12 px-4 sm:px-5 sm:w-auto" | ||
| className="rounded-full bg-black border border-solid border-transparent transition-colors flex items-center justify-center text-white gap-2 hover:bg-[#383838] dark:hover:bg-[#ccc] font-medium text-sm sm:text-base h-10 sm:h-12 px-4 sm:px-5 sm:w-auto" |
Owner
There was a problem hiding this comment.
Suggested change
| className="rounded-full bg-black border border-solid border-transparent transition-colors flex items-center justify-center text-white gap-2 hover:bg-[#383838] dark:hover:bg-[#ccc] font-medium text-sm sm:text-base h-10 sm:h-12 px-4 sm:px-5 sm:w-auto" | |
| className="rounded-full bg-black border border-solid border-transparent transition-colors flex items-center justify-center text-white gap-2 hover:bg-[#383838] dark:hover:bg-[#383838] font-medium text-sm sm:text-base h-10 sm:h-12 px-4 sm:px-5 sm:w-auto" |
The old hover color is really better than this all-white one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixed text visibility issues on the Home page by updating text color classes to ensure proper contrast against the dark background.
have also enhanced the Tailwind configuration with better color definitions for dark mode and text visibilitywith proper color variables for text-primary, text-secondary, and surface elements