Skip to content

do not wait timeout for no changed in record_version for expiry, trust the ttl_attribute #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

do not wait timeout for no changed in record_version for expiry, trust the ttl_attribute #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python_dynamodb_lock/python_dynamodb_lock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,8 @@ def acquire_lock(self,
last_record_version_number)
# if the record_version_number has not changed for more than _lease_duration period,
# it basically means that the owner thread/process has died.
last_version_elapsed_time = time.monotonic() - last_version_fetch_time
if last_version_elapsed_time > existing_lock.lease_duration:
logger.warning('Existing lock\'s lease has expired: %s', str(existing_lock))
if existing_lock.expiry_time < time.time():
logger.warning('Existing lock\'s lease has expired: %s (%s)', str(existing_lock), time.time())
self._overwrite_existing_lock_in_dynamodb(new_lock, last_record_version_number)
logger.debug('Added to the DDB. Adding to in-memory map: %s', new_lock.unique_identifier)
new_lock.status = DynamoDBLock.LOCKED
Expand Down