Skip to content

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Oct 17, 2025

Description

remove useless permissions

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Oct 17, 2025

⚠️ No Changeset found

Latest commit: 2d1fe3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 2d1fe3b
🔍 Latest deploy log https://app.netlify.com/projects/module-federation-docs/deploys/68f5a16cb53f4f0008aad05b
😎 Deploy Preview https://deploy-preview-4141--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@HigorAlves
Copy link

HigorAlves commented Oct 17, 2025

@2heal1 can you add:

e2e-metro:
    needs: [checkout-install, build-metro]

That should fix your pipeline.

@2heal1
Copy link
Member Author

2heal1 commented Oct 20, 2025

e2e-metro:
    needs: [checkout-install, build-metro]

yeah sure , updated

@2heal1
Copy link
Member Author

2heal1 commented Oct 20, 2025

@HigorAlves Hi , i add the above mentioned needs , but the CI still fail, can you help check how to fix it ?
cc @zackarychapple

@zackarychapple
Copy link
Collaborator

Checking! Thanks @2heal1

@HigorAlves
Copy link

@HigorAlves Hi , i add the above mentioned needs , but the CI still fail, can you help check how to fix it ? cc @zackarychapple

Can you give me more details about this PR and why those are being removed? Is it for security reasons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants