perf(test): make suite sharding configurable - #1057
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR extends the test-suite runner to support named test groups and uses it to shard the PTY integration suite.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or repository-rule violations identified. The grouped runner preserves existing argument and runtime contracts, current CI reaches the intended Linux sharding path, and platform-specific overrides remain explicit opt-ins. Important Files Changed
Reviews (1): Last reviewed commit: "perf(test): shard PTY integration suite" | Re-trigger Greptile |
f4c1a1d to
537da42
Compare
|
Force-pushed the stack after CI showed that concurrent PTY processes can starve a responsiveness test on hosted runners. PTY tests now stay serial by default; the runner still supports explicit measured shard counts and keeps filtered/coverage runs safe. This comment was generated by Pi using OpenAI GPT-5.6 Sol |
537da42 to
e8952c6
Compare
|
Fixed the file-backed reporter finding: Validation: Bun 1.4.2 runner tests (9 passed, 33 assertions), typecheck, and lint. This comment was generated by Pi using OpenAI GPT-5.6 Sol |
Problem
Hunk's test runner can shard only its default Linux suite. Other suites and CI platforms cannot reuse the independent-process supervision without duplicating it, while naïvely sharding filtered or coverage runs produces incorrect failures or output.
Approach
test:integrationthrough the same supervised runnerThis keeps Bun's isolated
--parallelmode disabled because it is incompatible with OpenTUI's native FFI initialization.Validation
./node_modules/.bin/bun test scripts/test/run-test-suite.test.ts./node_modules/.bin/bun run test./node_modules/.bin/bun run test:integration--test-name-patternbun run format:checkbun run lintbun run typecheckbun run deps:checkAn explicit two-shard PTY benchmark completed locally, but a hosted-runner responsiveness test exposed resource contention. PTY therefore remains serial by default; explicit sharding is available only for measured environments. Windows command construction is unit-tested here and exercised by the next PR.
Stack
Merge in this order.
This PR description was generated by Pi using OpenAI GPT-5.6 Sol