docs(everything): state that sampling/elicitation tools are absent from the catalog without the capability - #4793
Open
sasan1200 wants to merge 1 commit into
Conversation
…om the catalog without the capability The instructions string unconditionally referenced trigger-sampling-request and trigger-elicitation-request. Both tools register conditionally (only when the client declares the corresponding capability), so agents on non-capability clients were pointed at tools absent from their own tools/list catalog. Found with mcp-eval's catalog-vs-instructions checks; discussed in modelcontextprotocol#4792.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation accurately reflects the existing capability-based registration behavior.
Pull request overview
Clarifies capability-gated tool availability in the Everything server’s agent instructions.
Changes:
- States sampling and elicitation tools are absent unless clients declare the corresponding capability.
File summaries
| File | Description |
|---|---|
src/everything/docs/instructions.md |
Clarifies conditional tool catalog availability. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4792. The everything server's
instructionsstring unconditionally referencedtrigger-sampling-requestandtrigger-elicitation-request. Both tools register conditionally viaregisterConditionalTools()insideoninitialized— only when the client declares the corresponding capability — so an agent integrating with a non-capability client was instructed to use tools that never appear in itstools/listcatalog.Change
Two lines in
src/everything/docs/instructions.md, the filereadInstructions()serves as the instructions string:Sampling requests (trigger-sampling-request) require client sampling capability"Sampling requests (trigger-sampling-request) require the client to declare the sampling capability; without it, this tool is absent from the tool catalog"Same shape for the elicitation bullet. No code paths touched.
Verification
This was found with mcp-eval's catalog-vs-instructions checks against the published npm dist (v2026.8.31).