fix(oauth): The dynamic client registration should be optional #463
Conversation
github-actions
bot
added
T-core
Signed-off-by: jokemanfire <[email protected]>
| authorization_endpoint: create_endpoint("authorize"), | ||
| token_endpoint: create_endpoint("token"), | ||
| registration_endpoint: create_endpoint("register"), | ||
| registration_endpoint: None, |
There was a problem hiding this comment.
Given that supporting DCR is a SHOULD in the MCP spec, If we cannot get metadata at all and we construct these defaults, should we continue to populate a default uri here?
There was a problem hiding this comment.
It aimed to achieve better compatibility with the RFC 8414 protocol, according to the rfc 8414 , it should be optional
.
And in the spec file ,the registrat should be alt in the picture, and user can setting the client ID by himself which we provide this interface ,
There was a problem hiding this comment.
GitHub, for example, does not provide a value for registration_endpoint in their response, as they do not support DCR and require pre-registration of clients. (I had to make this same change in a fork, to support GitHub properly, and had not yet had an opportunity to open a PR here.)
The dynamic registration can be skipped, and it should be optional.
Motivation and Context
Accoding to rfc8414.
How Has This Been Tested?
No test
Breaking Changes
Types of changes
Checklist
Additional context