[Server] Fixed Discoverer file processing for PHAR #94
+22
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineersa
requested review from
chr-hertel,
Nyholm and
CodeWithKyrian
as code owners
chr-hertel
reviewed
Oct 7, 2025
|
Surprised that this is all what is needed - great :) Needs a rebase as well. |
Removed extension, rebased. Yeah, pretty much I do run llama.cpp/openwebui/MCPs on separate headless Linux machine, and for some reason I'm lazy to install PHP there, so I decided to wrap up MCP servers to a single file binaries which I can just |
|
Oh, please make sure your commit is signed |
Sorry signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
Discovererto work withSplFileInfoinstead of strings to have stream safe file operations.Added
tokenizerextension to requirements since it's important to know required extensions while building binaries andtoken_get_all()inside discovery uses it.Motivation and Context
Resolves #69
It allows building PHAR files with tools discovery and build binaries for easy MCP tools hosting
How Has This Been Tested?
Tested in MCP server with PHAR via
humbug/box- ineersa/python-mcp@f177ed5Breaking Changes
No
Types of changes
Checklist
Additional context