Skip to content

Conversation

chr-hertel
Copy link
Member

Missed to wire up the config correctly.

@chr-hertel chr-hertel added Bug Something isn't working Server Issues & PRs related to the Server component labels Sep 29, 2025
@CodeWithKyrian
Copy link
Contributor

Perfect. I was actually wondering if we still needed that Configuration DTO before this.

Though I’m thinking… what’s its role now, really? I first added it because there were too many parameters being passed around (server builder → server → handler), and I just wanted a typed object to hold all the configured services/settings in one place.

Right now it only has serverInfo, capabilities, paginationLimit, and instructions , but the JsonRpcHandler::make method still takes paginationLimit and the config object, which kinda defeats the point.

Also, that make method has quite a few arguments. Some of them (like toolCaller, resourceReader, promptGetter, maybe even the session store/factory...or not?) could fit nicely inside Configuration. Might be overkill anyways 😂, but since we already have it, maybe it’s worth thinking about.

Anyway, for now, removing the paginationLimit is a good start.

@chr-hertel chr-hertel force-pushed the bug-wire-instructions branch from 05407d2 to ada83bf Compare October 7, 2025 21:28
@chr-hertel
Copy link
Member Author

I like that it bundles some arguments into a structure - but it's not that semantically strong - that's true.

@chr-hertel chr-hertel merged commit cbd1b29 into main Oct 7, 2025
12 checks passed
@chr-hertel chr-hertel deleted the bug-wire-instructions branch October 7, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Server Issues & PRs related to the Server component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants