[Server] Implement variadic parameter handling in ReferenceHandler #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for variadic parameters (...) in prepareArguments method - Collect all numeric-indexed arguments starting from parameter position - Add proper error handling for variadic parameter processing - Remove TODO comment and complete the implementation - Maintain backward compatibility with existing parameter handling Fixes the TODO item in ReferenceHandler.php line 88 and enables proper handling of functions with variadic parameters in MCP tools and resources.
monayemislam
requested review from
chr-hertel,
Nyholm and
CodeWithKyrian
as code owners
chr-hertel
requested changes
Sep 6, 2025
There was a problem hiding this comment.
Hey @monayemislam, good catch that todo comment - thanks for picking up on that!
I made some smaller comments, but can you share how you tested this?
| $paramName = $parameter->getName(); | ||
| $paramPosition = $parameter->getPosition(); | ||
|
|
||
| // Handle variadic parameters |
There was a problem hiding this comment.
i think this is clear with the next line of code already and we can remove this comment
Suggested change
| // Handle variadic parameters |
Comment on lines
+95
to
+96
| foreach ($arguments as $key => $value) { | ||
| if (is_numeric($key) && $key >= $paramPosition) { |
There was a problem hiding this comment.
this reads like array_slice could be of help 👍
Comment on lines
+97
to
+103
| try { | ||
| $variadicArgs[] = $this->castArgumentType($value, $parameter); | ||
| } catch (InvalidArgumentException $e) { | ||
| throw RegistryException::invalidParams($e->getMessage(), $e); | ||
| } catch (\Throwable $e) { | ||
| throw RegistryException::internalError("Error processing variadic parameter `{$paramName}`: {$e->getMessage()}", $e); | ||
| } |
There was a problem hiding this comment.
this is basically the same like in line 112-118 - does it make sense to shift the throw RegistryException into the castArgumentType method instead and skip the try-catch in both cases?
or somehow merge this block into lower if-else part as well?
chr-hertel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the TODO item in ReferenceHandler.php line 88 and enables proper handling of functions with variadic parameters in MCP tools and resources.