This repository was archived by the owner on Aug 5, 2020. It is now read-only.
Open
Conversation
cdegit
reviewed
Apr 17, 2018
commands/preview.js
Outdated
|
|
||
| exports.command = function(url, bundle, callback) { | ||
| var browser = this; | ||
| exports.command = function(url, bundle = 'https://localhost:8443/loader.js', callback) { |
There was a problem hiding this comment.
Now that you're using es6 everything, do you still need to create the exports object? Or can you just say:
export const command = function(...)
Also, while you're at it, can you use an arrow function here?
Contributor
Author
There was a problem hiding this comment.
Addressed. Unfortunately we're unable to use an arrow function due to losing the ability to call 'argument.lengths'.
cdegit
reviewed
Apr 17, 2018
commands/triggerClick.js
Outdated
| @@ -1,13 +1,13 @@ | |||
| exports.command = function(selector, callback) { | |||
cdegit
reviewed
Apr 17, 2018
| "test": "./node_modules/.bin/grunt lint; ./node_modules/.bin/grunt test" | ||
| "test": "./node_modules/.bin/grunt lint; ./node_modules/.bin/grunt test", | ||
| "lint": "npm run lint:js", | ||
| "lint:js": "eslint '**/*.{js,jsx}'" |
There was a problem hiding this comment.
Might want to double check that this blob works on Windows. I've run into issues with commands before where the quotes used for this mattered to Windows and broke things. 😞
cdegit
reviewed
Apr 17, 2018
| "scripts": { | ||
| "install": "node selenium/install.js", | ||
| "test": "./node_modules/.bin/grunt lint; ./node_modules/.bin/grunt test" | ||
| "test": "./node_modules/.bin/grunt lint; ./node_modules/.bin/grunt test", |
There was a problem hiding this comment.
Should this be ; or &&? I don't actually remember what ; does 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status: Ready for Review or Open for Visibility
Owner:
Reviewers: @ellenmobify @jasecode
Changes
Todos:
grunt lint)Feedback:
none so far
How To Test
npm installnpm linknpm run lint