Pin ptrhash_bp #100
Merged
Pin ptrhash_bp #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udesou
approved these changes
Nov 3, 2025
udesou
left a comment
udesou
left a comment
There was a problem hiding this comment.
Could you add comments to those places just so we know the reason why we're adding those pins? Otherwise, LGTM.
qinsoon
force-pushed
the
pin-ptrhash-bp
branch
from
3f5fd00 to
3e312c3
Compare
Member
Author
Done. |
qinsoon
added a commit
that referenced
this pull request
Nov 4, 2025
`ptrhash_bp` may create an entry in the hashtable, and return a pointer that allows inserting a value as well. We need to pin both keys and values for `ptrhash_bp`. Related: mmtk/mmtk-julia#240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptrhash_bpmay create an entry in the hashtable, and return a pointer that allows inserting a value as well. We need to pin both keys and values forptrhash_bp.Related: mmtk/mmtk-julia#240