[Module] OpenAI Module without notebook #916
Conversation
danielperezz
left a comment
danielperezz
left a comment
There was a problem hiding this comment.
Looks good, a few comments :)
| @@ -0,0 +1,17 @@ | |||
| apiVersion: v1 | |||
| categories: | |||
| - general | |||
There was a problem hiding this comment.
general is only the kind, not a category. Try looking for appropriate categories from the hub filter menu.
| @@ -0,0 +1,4 @@ | |||
| fastapi>=0.110,<1.0 | |||
There was a problem hiding this comment.
The requirements.txt file is used to configure dependencies for unit test. Since there is no unit test, this file is not needed.
The module’s dependencies are specified in the item.yaml, but based on the code, it seems the user doesn’t actually need to have them installed, is that correct? If so, there’s no need to specify them at all.
| categories: | ||
| - general | ||
| description: OpenAI application runtime based on fastapi | ||
| example: openai_example.ipynb |
There was a problem hiding this comment.
| example: openai_example.ipynb | |
| example: openai.ipynb |
| mlrunVersion: 1.10.0 | ||
| name: openai | ||
| spec: | ||
| filename: openai_app.py |
There was a problem hiding this comment.
| filename: openai_app.py | |
| filename: openai.py |
| @@ -0,0 +1,39 @@ | |||
|
|
|||
There was a problem hiding this comment.
Stay consistent with the name of the module, rename this file to openai.py
2 participants
OpenAI Module without notebook