Skip to content

feat: enable repeating a transition by removing state check in setSta… #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

feat: enable repeating a transition by removing state check in setSta… #34

wants to merge 5 commits into from

Conversation

@simbig
Copy link
Contributor

@simbig simbig commented Jul 9, 2025 •
edited
Loading

  • Added automated tests
  • Documented for all relevant versions
  • Updated the changelog

Breaking changes

    • Execute transitions when repeatedly setting the same state

@simbig
Copy link
Contributor Author

simbig commented Jul 9, 2025

@spawnia can you check why the tests are not running correctly?

@simbig simbig requested a review from spawnia July 9, 2025 14:32
spawnia
spawnia reviewed Jul 9, 2025
View reviewed changes
@spawnia
Copy link
Member

spawnia commented Jul 9, 2025

@spawnia can you check why the tests are not running correctly?

Have you looked at the failing test case?

@simbig
Copy link
Contributor Author

simbig commented Jul 10, 2025

@spawnia can you check why the tests are not running correctly?

Have you looked at the failing test case?

Sorry my fault. The failing test case was hidden by the warnings. Fixed it.

Is there anything simple we can do about the warnings?

@simbig simbig requested a review from spawnia July 10, 2025 06:28
@spawnia
Copy link
Member

spawnia commented Jul 10, 2025

Is there anything simple we can do about the warnings?

I found laravel/framework#49502, but it seems that the general error with Laravel is fixed. Our error seemed to be specificly about lacking isolation between test cases. The unexpected Exception from one test case carried over to the other test cases. Not really sure what to do, but as long as all tests are working and clean up nicely after themselves, we have no problem.

Simon Bigelmayr added 2 commits August 14, 2025 07:29
Merge branch 'master' into enable-repeating-a-transition
1f2ee59 
# Conflicts:
#	CHANGELOG.md
#	app/ModelStates/ModelStates/ModelState.php
#	tests/ModelStates/StateTest.php
fix: reorder import statements for TransitionWithException in ModelSt…
91354f8 
…ate.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spawnia spawnia spawnia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simbig @spawnia