Skip to content

Conversation

@erinesullivan
Copy link
Contributor

Overview

"...it’s possible to use the down arrow in the page picker at the bottom of search results pages to scroll below page 1 (page 0, page -1, etc.)"

A min attribute has been added to the number input to force users into not selecting below 1.

This pull request resolves [LIBSEARCH-1135].

Anything else?

To add more restriction to user input, a max attribute has been added so the input cannot go beyond the max amount of pages.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Go to a results page with multiple pages of results.
    • Try and select below 1.
    • Try and select above the max amount of pages.

@erinesullivan erinesullivan self-assigned this Dec 17, 2025
@erinesullivan erinesullivan merged commit a340a41 into master Dec 17, 2025
9 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-1135-page-picker-in-search-allows-selecting-numbers-1 branch December 17, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants