- 
                Notifications
    You must be signed in to change notification settings 
- Fork 582
Submission dir update #2366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Submission dir update #2366
Conversation
| MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ | 
f1c882b    to
    91a71a0      
    Compare
  
    | ``` | ||
| ├── ... | ||
| │ ├── closed | ||
| │ │ ├── code | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pgmpablo157321 , would submitter name be there as parent folder of code,results and systems in new structure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should we put closed or open as parent of just results?
Also should we consider moving system.json under sut folder inside results directory and thus get rid of systems folder as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anandhu-eng Correct, I just pushed a fix for this
@arjunsuresh Not sure, we can discuss with the WG
| Hi @pgmpablo157321 , I was testing the changes. I was encountered with the following error: The detailed log could be found here. I think the issue is with the preprocessing script where it still modifies the results folder to compliance here. This leads the code to check for the following directory: closed/MLCommons/compliance/SR680a_V3_B200SXMx8_TRT/llama2-70b-99.9/Server The sample submission files(taken from inference_results_v5.1 repo) which was used to test the changes could be found here. | 
f59f94b    to
    37cb02d      
    Compare
  
    | Hi @pgmpablo157321 , this line from preprocess_submission.py triggers the following error: Please find the run logs here: | 
9d619aa    to
    57c1951      
    Compare
  
    | @anandhu-eng Pushed some fixes but two things seem to be failing: 
 | 
08abf0e    to
    4ec1f15      
    Compare
  
    fcb867f    to
    d54ff7f      
    Compare
  
    d54ff7f    to
    6700d92      
    Compare
  
    | Hi @pgmpablo157321 , the tests related to submission checker are passing(here) based on the test conditions mentioned in this issue. Let me know if we need any additional test case. | 
Uh oh!
There was an error while loading. Please reload this page.