Skip to content

Comments

fix(api): logout flow in the dashboard#1074

Merged
inimaz merged 5 commits intomasterfrom
fix/logout-flow
Feb 22, 2026
Merged

fix(api): logout flow in the dashboard#1074
inimaz merged 5 commits intomasterfrom
fix/logout-flow

Conversation

@inimaz
Copy link
Collaborator

@inimaz inimaz commented Feb 21, 2026

Description

The logout button in dashboard was not working properly (trhowing an error).

Now it removes the cookie and redirects to the base page.

@inimaz inimaz requested a review from a team as a code owner February 21, 2026 10:57
@codecov
Copy link

codecov bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.94%. Comparing base (cc62d32) to head (35417a1).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1074      +/-   ##
==========================================
+ Coverage   68.73%   69.94%   +1.20%     
==========================================
  Files          41       43       +2     
  Lines        3873     4062     +189     
==========================================
+ Hits         2662     2841     +179     
- Misses       1211     1221      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@SaboniAmine SaboniAmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Inigo!

@inimaz inimaz merged commit 91ec9ac into master Feb 22, 2026
11 checks passed
@inimaz inimaz deleted the fix/logout-flow branch February 22, 2026 10:31
davidberenstein1957 pushed a commit that referenced this pull request Feb 22, 2026
* fix(api): logout flow in the dashboard

* fix:allow only authenticated users to logout

* test: fix test_authenticate

* fix: move create_redirect_response to auth_provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants