Skip to content

Conversation

fiznool
Copy link

@fiznool fiznool commented Jul 15, 2016

Thanks for a great port of the Github library.

I'm offering this PR to cleanup a few things in the codebase, to make them a bit more friendly to what a node.js dev would expect in 2016. Here's a summary of the changes:

  • parse_reply renamed to parse.
  • String.prototype is no longer augmented, instead we use local functions for performing trim, chomp, etc.
  • The module is exported directly, meaning you get the whole module when you require('emailreplyparser').
  • Test dependencies added to package.json to make testing easier.
  • underscore replaced with lodash in the tests.
  • Code style cleaned up: use single quotes everywhere, add 'use strict' definitions, use triple equals where necessary.

I hope this is acceptable, if not then I'm happy to maintain my fork and publish to npm under a different name.

fiznool added 3 commits July 15, 2016 14:28
- `parse_reply` function is now called `parse`.
- Module is exported directly.
- String.prototype no longer polluted.
- Define dev dependencies in package.json.
- Code updated according to jshint styleguide.
@CTassisF
Copy link

CTassisF commented Sep 7, 2016

@fiznool Did you fork and publish to npm under a different name?

@fiznool
Copy link
Author

fiznool commented Sep 7, 2016

@CTassisF the changes are still in my fork at https://github.com/flowxo/emailreplyparser

I didn't publish anything to npm yet. If @mko doesn't reply in the next few weeks I'll look to do that. In the meantime you can depend on my fork directly. In your package.json:

"emailreplyparser": "github:flowxo/emailreplyparser#0834875

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants