Cleanup codebase, create v1 #6
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for a great port of the Github library.
I'm offering this PR to cleanup a few things in the codebase, to make them a bit more friendly to what a node.js dev would expect in 2016. Here's a summary of the changes:
parse_reply
renamed toparse
.String.prototype
is no longer augmented, instead we use local functions for performingtrim
,chomp
, etc.require('emailreplyparser')
.package.json
to make testing easier.underscore
replaced withlodash
in the tests.'use strict'
definitions, use triple equals where necessary.I hope this is acceptable, if not then I'm happy to maintain my fork and publish to npm under a different name.