fix(hdf-converters): warn on unmapped severities instead of silently mapping to impact 0 - #8617
Open
wdower wants to merge 1 commit into
Open
fix(hdf-converters): warn on unmapped severities instead of silently mapping to impact 0#8617wdower wants to merge 1 commit into
wdower wants to merge 1 commit into
Conversation
…mapping to impact 0 impactMapping() now distinguishes a mapping miss from a legitimate mapped 0.0: misses warn once per distinct value and default to a conservative 0.5 (caller-overridable) instead of returning 0, which hdf2ckl exported as Not_Applicable — silently removing open findings from checklists. Mirrors hdf-libs' severityToImpactWithAliases convention. Snyk expected-output fixtures updated: its map lacks 'critical', so those findings move from silent 0 to warned 0.5 (proper 0.9 mapping tracked separately). Root-cause fix for #8610. Signed-off-by: Will <will@dower.dev>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
impactMapping() now distinguishes a mapping miss from a legitimate mapped 0.0: misses warn once per distinct value and default to a conservative 0.5 (caller-overridable) instead of returning 0, which hdf2ckl exported as Not_Applicable — silently removing open findings from checklists. Mirrors hdf-libs' severityToImpactWithAliases convention.
Snyk expected-output fixtures updated: its map lacks 'critical', so those findings move from silent 0 to warned 0.5 (proper 0.9 mapping tracked separately).
Root-cause fix for #8610.