fix: コンパネからパスワードリセットした時に発生したエラーをダイアログで出す#17513
Open
samunohito wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #17513 +/- ##
===========================================
- Coverage 24.92% 24.89% -0.04%
===========================================
Files 1160 1160
Lines 39555 39553 -2
Branches 11016 11012 -4
===========================================
- Hits 9861 9846 -15
- Misses 23796 23806 +10
- Partials 5898 5901 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
Contributor
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -13563,6 +13563,24 @@
"$ref": "#/components/schemas/Error"
},
"examples": {
+ "NO_SUCH_USER": {
+ "value": {
+ "error": {
+ "message": "No such user.",
+ "code": "NO_SUCH_USER",
+ "id": "ccafc7fe-5074-4edd-9dc0-8ef9ef6a701d"
+ }
+ }
+ },
+ "CANNOT_RESET_PASSWORD_OF_ROOT_USER": {
+ "value": {
+ "error": {
+ "message": "Cannot reset password of the root user.",
+ "code": "CANNOT_RESET_PASSWORD_OF_ROOT_USER",
+ "id": "f28fc207-42ca-44c7-a577-44b4f0ec5999"
+ }
+ }
+ },
"INVALID_PARAM": {
"value": {
"error": { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
タイトルの通りです。
コンパネのパスワードリセット時にユーザが見つからない or rootユーザだった時のエラーがフロントエンドに伝わらない形となっていたため修正しました。
Why
fix #15788
Additional info (optional)
Checklist