Skip to content

fix: コンパネからパスワードリセットした時に発生したエラーをダイアログで出す#17513

Open
samunohito wants to merge 1 commit into
misskey-dev:developfrom
samunohito:enhance/15788-add-error
Open

fix: コンパネからパスワードリセットした時に発生したエラーをダイアログで出す#17513
samunohito wants to merge 1 commit into
misskey-dev:developfrom
samunohito:enhance/15788-add-error

Conversation

@samunohito
Copy link
Copy Markdown
Member

What

タイトルの通りです。
コンパネのパスワードリセット時にユーザが見つからない or rootユーザだった時のエラーがフロントエンドに伝わらない形となっていたため修正しました。

Why

fix #15788

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 30, 2026
@github-actions github-actions Bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels May 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.89%. Comparing base (d74b646) to head (8a7f5a4).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...d/src/server/api/endpoints/admin/reset-password.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17513      +/-   ##
===========================================
- Coverage    24.92%   24.89%   -0.04%     
===========================================
  Files         1160     1160              
  Lines        39555    39553       -2     
  Branches     11016    11012       -4     
===========================================
- Hits          9861     9846      -15     
- Misses       23796    23806      +10     
- Partials      5898     5901       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 307.83 MB 298.60 MB -9.23 MB -2.99%
VmHWM 307.83 MB 298.60 MB -9.23 MB -2.99%
VmSize 23172.77 MB 23163.59 MB -9.18 MB -0.03%
VmData 1373.34 MB 1364.13 MB -9.21 MB -0.67%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 307.85 MB 298.73 MB -9.12 MB -2.96%
VmHWM 307.85 MB 298.73 MB -9.12 MB -2.96%
VmSize 23173.36 MB 23163.59 MB -9.76 MB -0.04%
VmData 1373.93 MB 1364.13 MB -9.79 MB -0.71%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 308.34 MB 299.22 MB -9.12 MB -2.95%
VmHWM 308.34 MB 299.22 MB -9.12 MB -2.95%
VmSize 23173.52 MB 23163.67 MB -9.84 MB -0.04%
VmData 1374.09 MB 1364.22 MB -9.87 MB -0.71%

See workflow logs for details

@github-actions
Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -13563,6 +13563,24 @@
                   "$ref": "#/components/schemas/Error"
                 },
                 "examples": {
+                  "NO_SUCH_USER": {
+                    "value": {
+                      "error": {
+                        "message": "No such user.",
+                        "code": "NO_SUCH_USER",
+                        "id": "ccafc7fe-5074-4edd-9dc0-8ef9ef6a701d"
+                      }
+                    }
+                  },
+                  "CANNOT_RESET_PASSWORD_OF_ROOT_USER": {
+                    "value": {
+                      "error": {
+                        "message": "Cannot reset password of the root user.",
+                        "code": "CANNOT_RESET_PASSWORD_OF_ROOT_USER",
+                        "id": "f28fc207-42ca-44c7-a577-44b4f0ec5999"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

コンパネからパスワードをリセットした時にエラーが起こっても分かりにくい

1 participant