Skip to content

fix(backend): follow-up of #17415#17505

Merged
kakkokari-gtyih merged 2 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-17415
May 29, 2026
Merged

fix(backend): follow-up of #17415#17505
kakkokari-gtyih merged 2 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-17415

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

What

Cacheをdisposeするように

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 29, 2026
@github-actions github-actions Bot added the packages/backend Server side specific issue/PR label May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 303.67 MB 307.45 MB +3.78 MB +1.24%
VmHWM 303.67 MB 307.45 MB +3.78 MB +1.24%
VmSize 23169.11 MB 23172.22 MB +3.10 MB +0.01%
VmData 1369.13 MB 1372.65 MB +3.51 MB +0.25%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 303.78 MB 307.47 MB +3.69 MB +1.21%
VmHWM 303.78 MB 307.47 MB +3.69 MB +1.21%
VmSize 23169.28 MB 23172.63 MB +3.35 MB +0.01%
VmData 1369.30 MB 1373.07 MB +3.76 MB +0.27%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 304.20 MB 307.84 MB +3.63 MB +1.19%
VmHWM 304.20 MB 307.84 MB +3.63 MB +1.19%
VmSize 23169.28 MB 23172.72 MB +3.43 MB +0.01%
VmData 1369.38 MB 1373.15 MB +3.77 MB +0.27%

See workflow logs for details

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 29, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.89%. Comparing base (6237001) to head (3e65190).

Files with missing lines Patch % Lines
.../backend/src/server/oauth/OAuth2ProviderService.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17505      +/-   ##
===========================================
- Coverage    24.93%   24.89%   -0.04%     
===========================================
  Files         1160     1160              
  Lines        39550    39555       +5     
  Branches     11016    11008       -8     
===========================================
- Hits          9861     9848      -13     
- Misses       23791    23806      +15     
- Partials      5898     5901       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kakkokari-gtyih kakkokari-gtyih merged commit d74b646 into misskey-dev:develop May 29, 2026
41 of 43 checks passed
@kakkokari-gtyih kakkokari-gtyih deleted the fix-17415 branch May 29, 2026 11:40
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

1 participant