Skip to content

fix: フォロワー投稿をダイレクトで引用したときにダイレクトにする#15961

Open
KisaragiEffective wants to merge 4 commits into
developfrom
KisaragiEffective-patch-6
Open

fix: フォロワー投稿をダイレクトで引用したときにダイレクトにする#15961
KisaragiEffective wants to merge 4 commits into
developfrom
KisaragiEffective-patch-6

Conversation

@KisaragiEffective
Copy link
Copy Markdown
Collaborator

@KisaragiEffective KisaragiEffective commented May 5, 2025

What

fix #15561

Why

同上

Additional info (optional)

ユニットテストを追加したいのでdraft 別PRで対応

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook: 不要
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2025

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.89%. Comparing base (d127d82) to head (bd4c07f).
⚠️ Report is 784 commits behind head on develop.

Files with missing lines Patch % Lines
packages/backend/src/core/NoteCreateService.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15961       +/-   ##
============================================
- Coverage    46.13%   24.89%   -21.25%     
============================================
  Files         1769     1160      -609     
  Lines       182223    39554   -142669     
  Branches      5426    11017     +5591     
============================================
- Hits         84077     9845    -74232     
+ Misses       98117    23807    -74310     
- Partials        29     5902     +5873     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KisaragiEffective KisaragiEffective force-pushed the KisaragiEffective-patch-6 branch from a00c52b to db4b996 Compare May 10, 2025 03:36
@Sayamame-beans
Copy link
Copy Markdown
Member

テスト、一旦良いのではの気持ちになっています

@KisaragiEffective
Copy link
Copy Markdown
Collaborator Author

確かに

@KisaragiEffective KisaragiEffective marked this pull request as ready for review August 30, 2025 14:58
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 30, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Approved in [実験中] 管理用 Aug 30, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 296.09 MB 299.41 MB +3.31 MB +1.12%
VmHWM 296.09 MB 299.41 MB +3.31 MB +1.12%
VmSize 23161.09 MB 23164.21 MB +3.11 MB +0.01%
VmData 1361.06 MB 1364.84 MB +3.77 MB +0.27%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 297.02 MB 299.42 MB +2.40 MB +0.80%
VmHWM 297.02 MB 299.42 MB +2.40 MB +0.80%
VmSize 23162.18 MB 23164.46 MB 2.27 MB 0%
VmData 1362.14 MB 1365.09 MB +2.94 MB +0.21%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 297.34 MB 299.81 MB +2.46 MB +0.82%
VmHWM 297.34 MB 299.81 MB +2.46 MB +0.82%
VmSize 23162.18 MB 23164.46 MB 2.27 MB 0%
VmData 1362.14 MB 1365.09 MB +2.94 MB +0.21%

See workflow logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

フォロワー限定投稿を引用してダイレクト投稿を行うと公開範囲がフォロワー限定になってしまう

3 participants