Repository navigation
Conversation
This was referenced Apr 15, 2022
Merged
Member
|
Thanks @Ngoguey42! This fix is included in #406 (commit e5546a8), with regression tests, and will be part of 1.7.0. |
jmid
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 17, 2026
CHANGES: ## Added - Add `Stats.merge` and `Stats.merge_in`, to combine the statistics recorded by several domains (mirage/index#404, @lyrm) - Expose the Unix platform as `Index_unix.Private.Platform`, so that `Index.Make` can be applied to it directly (mirage/index#396, @art-w) - Document the file format of `Index_unix.Private.Raw` (mirage/index#380, @tomjridge, @balat) ## Changed - Breaking: OCaml 5.0 or later is now required (mirage/index#404, @lyrm) - Breaking: statistics are now recorded per domain, in a `Domain.DLS` key, instead of in a global value. `Stats.get` and `Stats.reset_stats` only see the calling domain (mirage/index#404, @lyrm) - Mirage support: `index` no longer depends on `unix`, and `index.unix` is now an optional library (mirage/index#396, @art-w) - Breaking: `Platform.S` and `Checks.Platform_args` now require a `Progress` and a `Fmt_tty` module, and `Private.Logs.setup` and `Private.Logs.setup_term` take an extra `(module Platform.FMT_TTY)` argument (mirage/index#396, @art-w) - Support cmdliner 2.0.0. Cmdliner 1.1.0 or later is now required (mirage/index#382, @MisterDA, mirage/index#402, @art-w) ## Fixed - Lock files are now opened with the `O_CLOEXEC` flag (mirage/index#394, @vect0r-vicall) - Read-only instances could return stale values after `sync`. `sync` now removes from their LRU the keys of the entries it loads, from the log or from the log used during merges. It also holds the lock that `find` takes, so that a concurrent `find` cannot cache an outdated value in the middle of a `sync` (mirage/index#398, mirage/index#399, @art-w, mirage/index#406, @balat) - Merges could lose entries, and `iter` could give wrong keys, when values are encoded on zero bytes and the key decoder returns its input string without copying it, as `Repr.decode_bin` does (mirage/index#387, @Ngoguey42) - Concurrent `find`s on distinct instances of the same `Index.Make` application, from several threads or domains, could miss bindings: they shared the buffer in which they prefetch entries of the data file. Each instance now has its own buffer, created with `Private.Io_array.prefetch_buffer` and passed to `Private.Io_array.v` (mirage/index#406, @balat) - `Index_unix.Private.Raw`: reading a truncated header now raises `Not_written`, as for a missing header, instead of failing an assertion. Writing a version that is not 8 bytes long raises `Invalid_argument`, and a write that makes no progress raises `Failure` instead of being dropped (mirage/index#406, @balat) - Add the missing `logs.threaded` dependency of the Unix tests (mirage/index#400, @anmonteiro)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.