Repository navigation
Point a failed check at the check, not at the test - #488
Merged
Merged
Conversation
Since mirage#451, a failure is located at the outermost frame of the test body, so a check in a helper called by the test reported the line of the call to the helper. 1.9.1 reported the line of the check, and Test.check still documents that Alcotest guesses the location of the check. A failed check now takes the innermost frame before Alcotest; other exceptions keep the line of the test body. Seen in owl 1.1, whose test_rough_cdf_matches reported line 779 (the List.iter) instead of line 757 (the check).
jmid
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 17, 2026
CHANGES: - Fix parallel test runs failing with `Failed 6 times to create symlink`, and a dangling `latest` link (mirage/alcotest#479, @samoht, fixes mirage/alcotest#471 and mirage/alcotest#472 in 1.10.0) - Fix tests failing with `EACCES` on a read-only source tree or with `DUNE_BUILD_DIR` (mirage/alcotest#480, @samoht, fixes mirage/alcotest#471 in 1.10.0) - Honour `ALCOTEST_SOURCE_CODE_POSITION` when set by the program before `run` (mirage/alcotest#481, @samoht, fixes mirage/alcotest#451 in 1.10.0) - Fix slow runs of suites with many cases of the same name (mirage/alcotest#482, @samoht, fixes mirage/alcotest#451 in 1.10.0) - Under Eio, point the failure locations added in 1.10.0 (mirage/alcotest#451) at the test, not at the scheduler (mirage/alcotest#484, fixes mirage/alcotest#478, @samoht, report by @talex5) - Point a failed `check` in a helper at the `check`, as in 1.9.1, not at the test that calls the helper (mirage/alcotest#488, @samoht, fixes mirage/alcotest#451 in 1.10.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #451, a failure is located at the outermost frame of the test body, so a failed
checkin a helper reports the line where the test calls the helper. 1.9.1 reported the line of thecheck, andTest.checkstill documents that Alcotest guesses the location of the check.A failed
checknow takes the innermost frame before Alcotest. Other exceptions keep the line of the test body.Seen in owl 1.1, where
test_rough_cdf_matchesreported line 779 (theList.iter) instead of line 757 (thecheck). The new case intest_failure_shapes.mlreproduces it, and fails without the change tocore.ml.