Repository navigation
Skip Eio frames when locating a failure - #484
Merged
Merged
Conversation
samoht
force-pushed
the
fix-eio-location
branch
9 times, most recently
from
November 12, 2026 14:16
c9106a9 to
6584cf4
Compare
A scheduler such as Eio runs a test in a fiber and re-raises its exception in the caller of its run function. The new case shows that the failure is then reported at the scheduler, not at the check.
Eio runs a test in a fiber and re-raises its exception in the caller of Eio_linux.run, so the outermost frame before Alcotest was in the scheduler: a failing check was reported at lib_eio_linux/sched.ml instead of the line of the test. Eio frames are now skipped, as Lwt and Async frames already are.
samoht
force-pushed
the
fix-eio-location
branch
from
November 12, 2026 14:50
6584cf4 to
a70f332
Compare
jmid
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 17, 2026
CHANGES: - Fix parallel test runs failing with `Failed 6 times to create symlink`, and a dangling `latest` link (mirage/alcotest#479, @samoht, fixes mirage/alcotest#471 and mirage/alcotest#472 in 1.10.0) - Fix tests failing with `EACCES` on a read-only source tree or with `DUNE_BUILD_DIR` (mirage/alcotest#480, @samoht, fixes mirage/alcotest#471 in 1.10.0) - Honour `ALCOTEST_SOURCE_CODE_POSITION` when set by the program before `run` (mirage/alcotest#481, @samoht, fixes mirage/alcotest#451 in 1.10.0) - Fix slow runs of suites with many cases of the same name (mirage/alcotest#482, @samoht, fixes mirage/alcotest#451 in 1.10.0) - Under Eio, point the failure locations added in 1.10.0 (mirage/alcotest#451) at the test, not at the scheduler (mirage/alcotest#484, fixes mirage/alcotest#478, @samoht, report by @talex5) - Point a failed `check` in a helper at the `check`, as in 1.9.1, not at the test that calls the helper (mirage/alcotest#488, @samoht, fixes mirage/alcotest#451 in 1.10.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under Eio, a failing check was reported where the scheduler re-raises it (
lib_eio_linux/sched.ml) rather than at the test, because Eio re-raises the exception in the caller ofEio_linux.run. Eio frames are now skipped, as Lwt and Async frames already are. Fixes #478, reported by @talex5.