Repository navigation
Read ALCOTEST_SOURCE_CODE_POSITION at each failure - #481
Merged
Merged
Conversation
samoht
force-pushed
the
fix-source-position
branch
6 times, most recently
from
November 12, 2026 12:33
27dd57d to
779781e
Compare
Since 1.10.0 the variable was read once, when Alcotest was initialised, so a program that turned it off with Unix.putenv before calling run still got the source position of each failure. 1.9.1 read it at each failure, and does again. In OCaml 4.14 to 5.3, Sys.getenv_opt raises Not_found internally when the variable is unset, which replaces the backtrace of the failure, so the backtrace is now read before the variable.
samoht
force-pushed
the
fix-source-position
branch
from
November 12, 2026 12:45
779781e to
b478f1c
Compare
jmid
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Nov 17, 2026
CHANGES: - Fix parallel test runs failing with `Failed 6 times to create symlink`, and a dangling `latest` link (mirage/alcotest#479, @samoht, fixes mirage/alcotest#471 and mirage/alcotest#472 in 1.10.0) - Fix tests failing with `EACCES` on a read-only source tree or with `DUNE_BUILD_DIR` (mirage/alcotest#480, @samoht, fixes mirage/alcotest#471 in 1.10.0) - Honour `ALCOTEST_SOURCE_CODE_POSITION` when set by the program before `run` (mirage/alcotest#481, @samoht, fixes mirage/alcotest#451 in 1.10.0) - Fix slow runs of suites with many cases of the same name (mirage/alcotest#482, @samoht, fixes mirage/alcotest#451 in 1.10.0) - Under Eio, point the failure locations added in 1.10.0 (mirage/alcotest#451) at the test, not at the scheduler (mirage/alcotest#484, fixes mirage/alcotest#478, @samoht, report by @talex5) - Point a failed `check` in a helper at the `check`, as in 1.9.1, not at the test that calls the helper (mirage/alcotest#488, @samoht, fixes mirage/alcotest#451 in 1.10.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 1.10.0 the variable was read once, when Alcotest was initialised, so a program that turned it off with
Unix.putenvbefore callingrunstill got the source position of each failure. 1.9.1 read it at each failure, and does again:Sys.getenv_optdoes not raise, so reading it there leaves the backtrace of the failure alone.