Skip to content

Read ALCOTEST_SOURCE_CODE_POSITION at each failure - #481

Merged
samoht merged 2 commits into
mirage:mainfrom
samoht:fix-source-position
Nov 12, 2026
Merged

samoht merged 2 commits into
mirage:mainfrom
samoht:fix-source-position

Conversation

@samoht

@samoht samoht commented Nov 10, 2026

Copy link
Copy Markdown
Member

Since 1.10.0 the variable was read once, when Alcotest was initialised, so a program that turned it off with Unix.putenv before calling run still got the source position of each failure. 1.9.1 read it at each failure, and does again: Sys.getenv_opt does not raise, so reading it there leaves the backtrace of the failure alone.

@samoht
samoht force-pushed the fix-source-position branch 6 times, most recently from 27dd57d to 779781e Compare November 12, 2026 12:33
Since 1.10.0 the variable was read once, when Alcotest was
initialised, so a program that turned it off with Unix.putenv before
calling run still got the source position of each failure. 1.9.1 read
it at each failure, and does again.

In OCaml 4.14 to 5.3, Sys.getenv_opt raises Not_found internally when
the variable is unset, which replaces the backtrace of the failure, so
the backtrace is now read before the variable.
@samoht
samoht force-pushed the fix-source-position branch from 779781e to b478f1c Compare November 12, 2026 12:45
@samoht
samoht merged commit 79a1a91 into mirage:main Nov 12, 2026
7 checks passed
@samoht
samoht deleted the fix-source-position branch November 12, 2026 13:42
jmid pushed a commit to ocaml/opam-repository that referenced this pull request Nov 17, 2026
CHANGES:

- Fix parallel test runs failing with `Failed 6 times to create symlink`, and
  a dangling `latest` link (mirage/alcotest#479, @samoht, fixes mirage/alcotest#471 and mirage/alcotest#472 in 1.10.0)
- Fix tests failing with `EACCES` on a read-only source tree or with
  `DUNE_BUILD_DIR` (mirage/alcotest#480, @samoht, fixes mirage/alcotest#471 in 1.10.0)
- Honour `ALCOTEST_SOURCE_CODE_POSITION` when set by the program before `run`
  (mirage/alcotest#481, @samoht, fixes mirage/alcotest#451 in 1.10.0)
- Fix slow runs of suites with many cases of the same name (mirage/alcotest#482, @samoht,
  fixes mirage/alcotest#451 in 1.10.0)
- Under Eio, point the failure locations added in 1.10.0 (mirage/alcotest#451) at the test,
  not at the scheduler (mirage/alcotest#484, fixes mirage/alcotest#478, @samoht, report by @talex5)
- Point a failed `check` in a helper at the `check`, as in 1.9.1, not at the
  test that calls the helper (mirage/alcotest#488, @samoht, fixes mirage/alcotest#451 in 1.10.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant