Open
Conversation
|
@minodisk, very interesting feature, please review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the preview functionality uses a query along the lines of
SELECT * FROM <table> {LIMIT <num_of_rows>}to visualize (a subset of) the rows of a table. Querying the entire table can be pretty costly however and theLIMITclause does not necessarily reduce the cost for non-clustered tables (see BigQuery API documentation).This pull request uses the getRows() alternative which doesn't incur any costs. It supports the current functionality to specify the number of rows returned but removes the job information as that is no longer applicable