Fix: Restrict --progress flag to GET command #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --progress flag was previously available for all commands, but it is only implemented for GET requests. This could be confusing for users. This commit moves the --progress argument from the common arguments to the GET parser, so it is only available for GET requests. A new test case has been added to verify that the --progress flag is not available for commands other than GET.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
mindedal
added a commit
that referenced
this pull request
Oct 29, 2025
The --progress flag was available for all commands, but it's only implemented for GET requests. This change restricts the --progress flag to the GET command to avoid confusion.
mindedal
added a commit
that referenced
this pull request
Nov 20, 2025
The --progress flag was available for all commands, but it's only implemented for GET requests. This change restricts the --progress flag to the GET command to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --progress flag was available for all commands, but it's only implemented for GET requests. This change restricts the --progress flag to the GET command to avoid confusion.
PR created automatically by Jules for task 10989237560524555892