chore(release skill): fix tag SHA check, last-tag discovery, hex.publish reality - #22
Merged
Conversation
…ex.publish reality
- Phase 3: replace 'git describe --tags --abbrev=0' (skips lightweight
tags, silently picks an older annotated tag — v0.4.0/v0.4.1 in this
repo were lightweight) with 'git tag --sort=-v:refname | head -1'.
- Phase 6: comparing 'gh api .../git/refs/tags/X --jq .object.sha' to
'git rev-parse X^{}' is always a mismatch for annotated tags (the
former is the tag-object SHA, the latter is the commit SHA). Verify
both layers explicitly: tag-object SHA against 'git rev-parse X',
then dereference via 'gh api .../git/tags/<sha>' for the commit SHA.
- Phase 6: 'mix hex.publish' blocks on 'Proceed? [Yn]' AND a 2FA code,
neither of which can be driven through Claude Code's Bash tool.
Spell out that the user must run it in their own terminal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fixes to
.claude/commands/release.mdlearned from the v0.5.0 release:LAST_TAGdiscovery.git describe --tags --abbrev=0skips lightweight tags and silently picks an older annotated tag (v0.4.0 / v0.4.1 in this repo were lightweight, so it returned v0.3.0). Switch togit tag --sort=-v:refname | head -1.gh api .../git/refs/tags/X --jq .object.sha(the tag-object SHA) togit rev-parse vX.Y.Z^{}(the commit SHA) is apples-to-oranges. Verify both layers: tag-object SHA againstgit rev-parse vX.Y.Z, then dereference viagh api .../git/tags/<sha>for the commit SHA.mix hex.publishreality. Blocks onProceed? [Yn]and a 2FA code, neither of which can be supplied through Claude Code's Bash tool. Make explicit that the user must run it in their own terminal.Test plan
/releasenext time around