Skip to content

test(cli): cover staged rule parity - #1719

Merged
aidenybai merged 1 commit into
mainfrom
codex/fix-1691
Aug 30, 2026
Merged

test(cli): cover staged rule parity#1719
aidenybai merged 1 commit into
mainfrom
codex/fix-1691

Conversation

@aidenybai

Copy link
Copy Markdown
Member

Summary

  • reproduce the reported no-clone-element case with a newly staged file
  • verify that full and staged scans both report the enabled rule
  • keep the check at the built CLI boundary, including config loading and Git index materialization

Current main already has the expected behavior, so this PR adds only the regression guard.

Validation

  • nr test
  • nr lint
  • nr typecheck
  • nr format:check
  • nr build
  • nr smoke:json-report

Closes #1691

@pkg-pr-new

pkg-pr-new Bot commented Aug 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1719
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1719
npm i https://pkg.pr.new/react-doctor@1719

commit: afc4b36

@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit afc4b36.

@github-actions

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

Terminal Control verified the built CLI at afc4b36 in a real PTY:

  • selected a project interactively and observed Scanning... before the three-second Git delay completed
  • waited for the clean result and exercised the compact report
  • opened copy context and the GitHub Actions confirmation, then cancelled safely

Download the edited MP4 and PNG evidence

@aidenybai
aidenybai merged commit 71800cc into main Aug 30, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--staged misses react-doctor/no-clone-element that the full scan catches on the same file

1 participant