fix(core): resolve local Expo Metro config wrappers - #1718
Merged
Conversation
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
skoshx
marked this pull request as ready for review
August 30, 2026 04:25
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
expo-metro-configonly read the root Metro config. It reported a false positive when that file delegated to a local helper that importedexpo/metro-config, including the reproduction in #1715.Before: any local helper hid the valid Expo signal from the check.
After: the check follows statically resolvable runtime imports inside the project and reports only when the reachable config graph has no Expo signal.
What changed
posthog-react-native/metroExpo wrapper.@react-doctor/core.Test plan
nr testnr lintnr typechecknr format:checknr buildnr smoke:json-reportREACT_DOCTOR_NO_TELEMETRY=1 nlx react-doctor@latest --verbose --scope changed— 100/100RDE was not run because this is a core Expo project check, not an Oxlint rule.
Closes #1715