fix(cli): check root workflow before recommending CI - #1697
Merged
Conversation
Multi-project scans were unconditionally recommending GitHub Actions even when already existed at the repository root. The logic checked individual project directories for the workflow, which would fail in monorepos where the workflow lives at the root. Fixed by checking whether CI is configured at the root directory (where the scan is running) instead of: 1. Unconditionally for multi-project scans (projectScans.length > 1) 2. Per-project directory checks that miss root-level workflows Closes #1696 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tui.ci_recommendation_shownonly when the report displays the recommendation.Product brief
tui.ci_recommendation_shownmeasures actual recommendation displays.Validation
Closes #1696