fix(core): preserve settings from adopted lint configs - #1695
Merged
Conversation
- Read settings from adopted lint configs via readAdoptedLintConfigSettings - Merge adopted settings (e.g. tailwindcss.entryPoint) with react-doctor settings - Exclude react-doctor settings from adoption to avoid circular override - Add comprehensive tests for settings adoption and merging - Add user-tailwind-config fixture to verify Tailwind settings adoption Fixes #1694 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
August 30, 2026 05:26
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.oxlintrc.jsonor.eslintrc.jsonextendsProduct check
rule.firedandlint.failedsignals cover adopted plugin behavior. No new metric is needed.lint.failedby more than 1% across two releases.Validation
nr testnr lintnr typechecknr format:checknr buildnr smoke:json-reportCloses #1694