fix(cli): clean up interactive terminal transitions - #1582
Merged
Conversation
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ERecorded from the built CLI at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Two adjacent interactive transitions left the terminal in the wrong state:
After: project selection is disposable, while scan results are durable. Choosing a project restores the normal terminal before scanning; cancelling a completed report keeps its final score/results visible and appends exactly one cancellation footer.
Product brief:
alternateScreen, active-renderer lifecycle, and idempotent disposal instead of introducing another renderer or output mode.tui.project_select_shown; retain the existingtui.cancelledcounter for cancellation behavior.What changed
tui.project_select_shownTest plan
nr testnr lintnr typechecknr format:checknr smoke:json-reportnpx -y react-doctor@latest --verbose --scope changedCancelled.footer