fix(effect-needs-cleanup): prove effect-owned cleanup

[skoshx]

Why

effect-needs-cleanup still reports safe effects and accepts unsafe effects when cleanup ownership is expressed through returned listener disposers, mapped subscription collections, or guarded effect-local timer helpers. This builds on #1564 with the adversarial ownership cases that were not covered there.

The need remains reproducible on current main: its copied adversarial suite fails 70 of 160 cases.

What changed

• Accept callable disposers returned by non-DOM addEventListener and addListener APIs while preserving DOM, legacy media-query, and React Native subscription-object diagnostics.
• Prove mapped disposer/subscription collections are cleaned exhaustively through forEach or for...of, rejecting conditional cleanup, the wrong collection, escaped collections, and dropped or overwritten entries.
• Follow directly invoked effect-local helpers and synchronous iterator callbacks when checking collection mutations; ignore uninvoked helpers.
• Accept effect-owned nested timers only when handle storage, callback ownership, invocation paths, assignments, overwrite protection, and cleanup coverage are all proven.
• Reject async/deferred owners, sibling-effect timers, imported DOM wrappers, cleanup-after-reschedule patterns, and incomplete ownership.
• Expand the fuzz generator, verdict-preserving mutations, regression corpus, and false-positive hunter for these patterns.

Validation

Check	Result
Current-main necessity reproduction	70 failed / 90 passed in the 160-case adversarial suite
Focused issue #1558 adversarial suite	196/196 passed
Strict targeted fuzz	25,000 seeded generated/mutated cases with invariants and strict mode; passed
Exact-base local RDE	100 project roots across 8 repositories; 51 vs. 51 target-rule diagnostics; identical canonical digest
Full local gates	test, lint, typecheck, format check, and JSON smoke passed
GitHub CI	Running on 14136e860
Daytona parity	Not available in this environment; the exact same-corpus local RDE comparison above completed

Test plan

• nr test
• nr lint
• nr typecheck
• nr format:check
• nr smoke:json-report
• nr -C packages/oxlint-plugin-react-doctor test effect-needs-cleanup.issue-1558.test.ts
• FUZZ_RULE=effect-needs-cleanup FUZZ_ITERATIONS=25000 FUZZ_SEED=8675309 FUZZ_INVARIANTS=1 FUZZ_STRICT=1 nr fuzz

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1559

npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1559

npm i https://pkg.pr.new/react-doctor@1559

commit: 14136e8

[github-actions]

Interactive terminal E2E

Recorded from the built CLI at 6beed44 in a real terminal. The fixture holds Git busy for three seconds, so Scanning... must appear immediately after project selection, then exercises the compact interactive report.

Download the GIF and MP4 artifact

[aidenybai]

Superseded by #1564, which carries the current implementation on top of main, includes the cleanup path-coverage review fix, and has the focused/fuzz validation. Closing this older failing-CI branch to avoid merging duplicate detector changes.

[aidenybai]

Superseded by #1564, which landed the cleanup-ownership fix with focused regression coverage and the FPFNFIX82 ship checks.