fix(action): improve ensure-json-report error messages - #1332
Draft
skoshx wants to merge 4 commits into
Draft
Conversation
Contributor
📦 GitHub Action release recommendedThis PR changes the React Doctor GitHub Action's release surface:
The composite action is versioned independently from the npm packages, so it After merging, cut the tag from the merge commit on git checkout main && git pull --ff-only
merge_commit=$(git rev-parse HEAD)
git tag -a v2.2.9 "$merge_commit" -m "react-doctor action v2.2.9"
git tag -fa v2 "$merge_commit" -m "react-doctor action v2 (floating major -> v2.2.9)"
git push origin v2.2.9
git push --force origin v2 # moves only the floating major pointerThis bump can also be performed automatically on merge — set the repo |
commit: |
aidenybai
force-pushed
the
cursor/triage-1331-e774
branch
from
July 20, 2026 16:21
a3f23c4 to
136a3be
Compare
- Add specific error messages for different failure scenarios - Distinguish between empty reports, invalid JSON, missing schema version, unsupported schema version, and missing ok field - Guide users to update the action when schema version mismatch occurs - Provide actionable error messages instead of generic 'exited before producing' message Fixes #1331 Co-authored-by: Skosh <skoshx@users.noreply.github.com>
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
Co-authored-by: Skosh <skoshx@users.noreply.github.com>
aidenybai
force-pushed
the
cursor/triage-1331-e774
branch
from
July 20, 2026 16:26
136a3be to
47a6a74
Compare
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the GitHub Action receives a missing, malformed, or incompatible CLI report,
ensure-json-report.mjsreplaces it with a generic fallback. The fallback hides whether the CLI produced no file, empty output, invalid JSON, an unsupported schema, or an incomplete report.Solution
Validation
okreports.Release note
This touches
scripts/ensure-json-report.mjs, so it needs a patch GitHub Action release after merge. It does not require an npm package release.Closes #1331