Refine architecture audit findings - #1076
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
diagnose(..., { lint: false })by swapping the API linter layer to the no-op layer, matching the existing public option contract.ScanResultfinding categories and refresh related docs/tests.Product brief
Job: Developers and CI consumers need existing skip/report knobs to be trustworthy without learning new options.
Change: Reuse existing
lint,surfaces,ignore.overrides, and--fail-on-issuessurfaces; no new public flags or report fields.Reuse: Reused
isSameRuleKey/rule aliasing viaisRuleKeyInSet; truffler could not run because the VM lacksbun, so focused repository search plus parallel reviewers checked for duplicates.Metric: Existing scan outcome and CLI invocation telemetry remain sufficient because this fixes current behavior rather than adding a new adoption surface.
Compat: Patch changeset for published docs/CLI behavior; no JSON schema change; no GitHub Action files touched.
Kill: N/A for new surface because no new surface was added.
Verification
pnpm buildpnpm test(root)pnpm typecheckpnpm lint(passed with pre-existing warnings only)pnpm smoke:json-reportpnpm format:checkpackages/api:pnpm testpackages/deslop-cli:pnpm testpackages/core:vp test run tests/filter-for-surface.test.ts tests/filter-diagnostics.test.ts tests/discover-project.test.tsSkipped from the broad audit
run-inspect.ts,inspect.ts, action.yml, and deslop-js entry-resolution decompositions: worthwhile but high-churn and best split into separate PRs.