Skip to content

Refine architecture audit findings - #1076

Draft
cursor[bot] wants to merge 2 commits into
mainfrom
aiden/codebase-architecture-elegance-b926
Draft

Refine architecture audit findings#1076
cursor[bot] wants to merge 2 commits into
mainfrom
aiden/codebase-architecture-elegance-b926

Conversation

@cursor

@cursor cursor Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Make rule-key ignore overrides and surface filters alias-aware through a shared core helper.
  • Honor diagnose(..., { lint: false }) by swapping the API linter layer to the no-op layer, matching the existing public option contract.
  • Update deslop CLI output/gating to include all current ScanResult finding categories and refresh related docs/tests.
  • Normalize project discovery cache keys, sort workspace discovery results, and fix stale shipped docs/demo rule keys.

Product brief

Job: Developers and CI consumers need existing skip/report knobs to be trustworthy without learning new options.
Change: Reuse existing lint, surfaces, ignore.overrides, and --fail-on-issues surfaces; no new public flags or report fields.
Reuse: Reused isSameRuleKey/rule aliasing via isRuleKeyInSet; truffler could not run because the VM lacks bun, so focused repository search plus parallel reviewers checked for duplicates.
Metric: Existing scan outcome and CLI invocation telemetry remain sufficient because this fixes current behavior rather than adding a new adoption surface.
Compat: Patch changeset for published docs/CLI behavior; no JSON schema change; no GitHub Action files touched.
Kill: N/A for new surface because no new surface was added.

Verification

  • pnpm build
  • pnpm test (root)
  • pnpm typecheck
  • pnpm lint (passed with pre-existing warnings only)
  • pnpm smoke:json-report
  • pnpm format:check
  • packages/api: pnpm test
  • packages/deslop-cli: pnpm test
  • packages/core: vp test run tests/filter-for-surface.test.ts tests/filter-diagnostics.test.ts tests/discover-project.test.ts

Skipped from the broad audit

  • Large run-inspect.ts, inspect.ts, action.yml, and deslop-js entry-resolution decompositions: worthwhile but high-churn and best split into separate PRs.
  • GitHub Action release-surface fixes: avoided here to prevent triggering independent action tagging requirements.
  • Full AST walker/scope-system consolidation in the oxlint plugin: needs rule validation/RDE coverage beyond this cleanup slice.
Open in Web View Automation 

cursoragent and others added 2 commits July 6, 2026 16:28
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>
Co-authored-by: Aiden Bai <aidenybai@users.noreply.github.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@pkg-pr-new

pkg-pr-new Bot commented Jul 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1076
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1076
npm i https://pkg.pr.new/react-doctor@1076

commit: 14587c1

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 14587c1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant