Skip to content

Deduplicate rule utilities and remove dead deslop internals - #1066

Merged
aidenybai merged 1 commit into
mainfrom
aiden/codebase-architecture-elegance-d8b5
Aug 4, 2026
Merged

Deduplicate rule utilities and remove dead deslop internals#1066
aidenybai merged 1 commit into
mainfrom
aiden/codebase-architecture-elegance-d8b5

Conversation

@cursor

@cursor cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Reuse canonical rule-key matching and shared JSX helpers instead of parallel implementations.
  • Reuse the canonical React Native shadow-style constant.
  • Remove dead deslop semantic/AST internals and a no-op empty entry glob.
  • Discard the original branch's unsafe Fast Refresh rewrite.

Verification

  • Full oxlint plugin suite: 986 files / 25,940 tests passed.
  • Deslop suite: 520 tests passed.
  • nr typecheck
  • nr lint (passes with baseline warnings)
  • nr format:check
  • git diff --check
  • Truffler pre/post deduplication search

Note

Low Risk
Mostly deduplication and dead-code removal with equivalent logic paths; the deslop entry-glob removal only drops a no-op scan.

Overview
Refactors shared matching and lint helpers without changing intended behavior: the diagnostic pipeline replaces separate ignore/app-only checks with one alias-aware matchesRuleKey helper and reuses a single ruleIdentifier through filtering and inline suppressions.

Deslop cleanup removes the unused contextStatus / contextMessage field from semantic analysis results (failures still surface via errors), deletes unused OXC AST child helpers, and stops scanning with an empty SCRIPT_ENTRY_PATTERNS glob that never matched anything.

Oxlint plugin routes forbid-elements, jsx-pascal-case, and spread-override messaging through existing shared utilities, and the React Native shadow rule uses the canonical LEGACY_SHADOW_STYLE_PROPERTIES set instead of a local duplicate.

Reviewed by Cursor Bugbot for commit 71799cd. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rde parity

View PR

Open in Web View Automation 

Sent by Cursor Automation: React Doctor Cleanup

@aidenybai
aidenybai force-pushed the aiden/codebase-architecture-elegance-d8b5 branch from 0572e6d to 71799cd Compare August 3, 2026 21:39
@pkg-pr-new

pkg-pr-new Bot commented Aug 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@1066
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@1066
npm i https://pkg.pr.new/react-doctor@1066

commit: 71799cd

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

React Doctor interactive terminal recording

Recorded from the built CLI at 71799cd in a real terminal. The fixture holds Git busy for three seconds, so Scanning... must appear immediately after project selection, then exercises the compact interactive report.

Download the GIF and MP4 artifact

@aidenybai aidenybai changed the title Refactor duplicated rule and deslop internals Deduplicate rule utilities and remove dead deslop internals Aug 3, 2026
@aidenybai
aidenybai marked this pull request as ready for review August 3, 2026 21:59

@aidenybai aidenybai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed after rebasing and narrowing against current main. The retained helper deduplication and dead-code removals are covered by full plugin/deslop suites and the complete CI matrix is green after the unrelated macOS timing flake passed on rerun.

@aidenybai
aidenybai merged commit 4a107ea into main Aug 4, 2026
37 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant