Deduplicate rule utilities and remove dead deslop internals - #1066
Merged
Conversation
aidenybai
force-pushed
the
aiden/codebase-architecture-elegance-d8b5
branch
from
August 3, 2026 21:39
0572e6d to
71799cd
Compare
commit: |
Contributor
Interactive terminal E2ERecorded from the built CLI at |
aidenybai
marked this pull request as ready for review
August 3, 2026 21:59
aidenybai
approved these changes
Aug 3, 2026
aidenybai
left a comment
Member
There was a problem hiding this comment.
Reviewed after rebasing and narrowing against current main. The retained helper deduplication and dead-code removals are covered by full plugin/deslop suites and the complete CI matrix is green after the unrelated macOS timing flake passed on rerun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Verification
nr typechecknr lint(passes with baseline warnings)nr format:checkgit diff --checkNote
Low Risk
Mostly deduplication and dead-code removal with equivalent logic paths; the deslop entry-glob removal only drops a no-op scan.
Overview
Refactors shared matching and lint helpers without changing intended behavior: the diagnostic pipeline replaces separate ignore/app-only checks with one alias-aware
matchesRuleKeyhelper and reuses a singleruleIdentifierthrough filtering and inline suppressions.Deslop cleanup removes the unused
contextStatus/contextMessagefield from semantic analysis results (failures still surface viaerrors), deletes unused OXC AST child helpers, and stops scanning with an emptySCRIPT_ENTRY_PATTERNSglob that never matched anything.Oxlint plugin routes
forbid-elements,jsx-pascal-case, and spread-override messaging through existing shared utilities, and the React Native shadow rule uses the canonicalLEGACY_SHADOW_STYLE_PROPERTIESset instead of a local duplicate.Reviewed by Cursor Bugbot for commit 71799cd. Bugbot is set up for automated code reviews on this repo. Configure here.