fix(scraper): RRP sanity guardrail and always-record manual confirmations - #65
Merged
Conversation
…ions Original-price candidates come partly from generic strikethrough/'was'-style selectors that can match unrelated numbers (financing text, bundle offers, related-product cards), and their consensus had no plausibility check — so the recorded RRP jumped between stray values. Consensus now discards an original price below the resolved standard price or more than 10x above it. Manual confirmations (troubleshoot/re-scan) previously did nothing when the selected price equaled the latest recorded one; they now always record a fresh history row and refresh the anchor and extraction method, which is what repopulates a stale product. Part of #55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code-level fixes for the reproducible parts of #55:
was-style selectors can match unrelated page numbers (financing text, bundle offers, related-product cards) and nothing sanity-checked them before recordingThe remaining question in #55 — why the specific JB Hi-Fi RRP values fluctuated — needs the reporting instance's
retailer_configsrow and scrape traces; the guardrail neutralizes the failure mode either way.Validation
Part of #55