Skip to content

fix(scraper): resolve audit findings for O-6, O-7, A-15, and SYS-15 - #100

Open
stevene1919 wants to merge 1 commit into
mainfrom
fix/audit-a15-o6-o7-sys15
Open

fix(scraper): resolve audit findings for O-6, O-7, A-15, and SYS-15#100
stevene1919 wants to merge 1 commit into
mainfrom
fix/audit-a15-o6-o7-sys15

Conversation

@stevene1919

Copy link
Copy Markdown
Collaborator

Summary

  • O-6: Upgraded the requestId generation from low-entropy random/timestamp strings to v4 randomUUID in orchestration/index.ts and transport/remote.ts.
  • O-7: Fixed isShellConfig to properly check !domainConfig.jsonld_price_key in orchestration/index.ts, preventing configurations utilizing only a JSON-LD price key from being treated as minimal shell configs.
  • A-15: Changed retry warning messages in retry.ts to log under their actual passed category context instead of hardcoding the 'AI' tag.
  • SYS-15: Implemented a 10-second timeout configuration for external Frankfurter rate updates in CurrencyConversionService.ts.

Validation

  • Verified backend test suite: all 121 vitest test cases passed successfully.
  • Verified request ID formatting: confirmed REQ-[UUID] outputs correctly (e.g., REQ-33b1afcb-b5f0-4d1b-bd14-2e17f4b3102c) inside the running backend container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant