Skip to content

Styling on body element confusing when looking at tests? #43

Description

@jgwhite

Because there are some styles on <body> in app/index.html that aren’t (and can’t be) present in tests/index.html we have a mismatch between how the app looks in acceptance tests vs. when it’s running for real:

Screen Shot 2019-11-14 at 12 33 41

We could fix this by moving the containing styles into app/template/application.hbs, i.e.:

<div class="font-sans antialiased h-screen flex">
  {{outlet}}
</div>

This implies also updating the starter HTML and various intermediate steps.

If this change is desirable, let me know and I’ll throw together a PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions