Conversation
midagedev
added a commit
that referenced
this pull request
Sep 9, 2026
…K-1701) The three theme paragraphs stay; the incident narration inside them goes. English 3,456 → 2,318 words, Korean and Japanese cut in the same shape. Every GDK key, every number, command, path and link is preserved — tools/changelog-preserve.sh is green on the heading, key, tail and number axes for all three files. The code-span axis reports only spans the old text had split across a line break, now on one line, plus the GDK-1697 sentence (its tail is defined here; the PR carrying the code is #99). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ckout stop sharing a home by default
GDK-1687 made a dev build refuse to migrate a release-written mirror, but
both binaries still looked at ~/.gadak, so the refusal guarded the schema
only; config.json, pairing, local.db and the built-in persist stayed shared
and the refusal fired on every dev run. With GADAK_HOME unset a dev build
(skillinstall.IsDevBuild — now also "dev", desktop's unstamped default,
which had been counting as a release) resolves its home to ~/.gadak-dev;
GADAK_HOME wins for both builds, and that explicit case is where GDK-1687's
refusal still stands. config.SetDevBuild is called first thing by
cmd/gadak, desktop and apprun; doctor prints home with the reason
("dev build" / "GADAK_HOME").
Measured: dev doctor with no GADAK_HOME → ~/.gadak-dev (dev build);
GADAK_HOME=… → that path (GADAK_HOME); -X main.version=0.21.0 → ~/.gadak.
go build/vet/gofmt, config/skillinstall/apprun/cmd tests, desktop build,
doc-checks, scan-internal green.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GDK-1687 (user decision 2026-09-09): with
GADAK_HOMEunset a dev build resolves its home to~/.gadak-dev, the installed release keeps~/.gadak, so the two never share workspace files by accident.GADAK_HOMEwins for both builds; a dev build pointed at a real home on purpose still gets GDK-1687's forward-migration refusal.skillinstall.IsDevBuildnow also recognises"dev", desktop's unstamped default, which had been counting as a release build.gadak doctorprintshomewith the reason.Touches
desktop/main.go(one line before the log dir resolves), hence the PR.Measured with a fresh HOME: dev build →
~/.gadak-dev (dev build);GADAK_HOME=…→ that path(GADAK_HOME);-X main.version=0.21.0→~/.gadak.🤖 Generated with Claude Code