ci: staticcheck becomes a gate (--warn-only dropped) - #98
Merged
Conversation
…m list is empty The 14 findings the flag was covering are closed (b5bf3b8); a finding all three GOOS agree on now fails the job. CLAUDE.md's clause says so instead of counting the old backlog. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The staticcheck job ran `--warn-only` while the cross-platform findings were triaged (GDK-1463). That list reached zero on main in b5bf3b8, so this drops the flag: a finding every GOOS agrees on now fails CI. Job renamed from "Staticcheck (warning-only)" to "Staticcheck"; CLAUDE.md's clause updated to match.
Workflow-only change, so it goes through a PR for the branch verdict. Locally `bash tools/staticcheck.sh` on main prints `summary: 0 cross-platform, 0 platform-only, ST1005 excluded` and exits 0.
🤖 Generated with Claude Code