Skip to content

Conversation

@mercyblitz
Copy link
Contributor

@mercyblitz mercyblitz commented Oct 27, 2025

This pull request focuses on updating version numbers and enhancing the WebEndpointMapping class to improve equality checks and JSON serialization. The most important changes are grouped below:

Version Updates:

  • Updated the latest versions for the 0.2.x and 0.1.x branches in README.md to 0.2.4 and 0.1.4 respectively.
  • Updated the project revision property in pom.xml from 0.1.3-SNAPSHOT to 0.1.4-SNAPSHOT.

Enhancements to WebEndpointMapping:

  • Improved the equals method in WebEndpointMapping to include the kind field in equality checks, ensuring more accurate object comparisons.
  • Enhanced the toJSON method and related helper methods in WebEndpointMapping to serialize the kind field, and updated the corresponding JSON test resource to include "kind":"CUSTOMIZED". [1] [2] [3]

Testing Improvements:

  • Added a test case in WebEndpointMappingTest to verify that mappings with different kind values are not considered equal.

Documentation:

  • Corrected minor formatting in the JavaDoc example usage for BeanPropertyChangedEvent.

Changed the Javadoc heading from 'Example usage:' to 'Example Usage' in BeanPropertyChangedEvent.java for consistency with documentation style.
Updated all Javadoc and code references from javax.servlet to jakarta.servlet to align with the latest Servlet API package. Also fixed equals() to compare kind and added kind to JSON output for improved serialization.
Introduced a new 'kind' field with value 'CUSTOMIZED' in the web-mapping-descriptor.json for test resources. This may be used to distinguish mapping types in tests.
Updated the <revision> property in pom.xml to prepare for the next development iteration.
Bump the documented latest version of the 0.1.x branch from 0.1.3 to 0.1.4 to reflect the most recent release.
Updated all Javadoc references from jakarta.servlet to javax.servlet to ensure compatibility with environments using javax.servlet APIs. No functional code changes were made.
Added an assertion to verify that WebEndpointMapping objects with different kinds are not equal. This improves test coverage for the equals method.
@sonarqubecloud
Copy link

@mercyblitz mercyblitz changed the title Release 0.2.4 Release 0.1.4 Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ Complexity Δ
...spring/context/event/BeanPropertyChangedEvent.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
...sphere/spring/web/metadata/WebEndpointMapping.java 100.00% <100.00%> (ø) 54.00 <1.00> (+2.00)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mercyblitz mercyblitz merged commit cec5abb into release-1.x Oct 27, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants