feat: Update discriminator optimization when it has mixed fields#305
Open
mohankumarelec wants to merge 1 commit intomicrosoft:mainfrom
Open
feat: Update discriminator optimization when it has mixed fields#305mohankumarelec wants to merge 1 commit intomicrosoft:mainfrom
mohankumarelec wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@aeschli , Please take a loot into this and let me know if it looks good, Thanks. Feel free to edit the PR if required |
mohankumarelec
force-pushed
the
discriminator-update
branch
from
63603e5 to
cadbbd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the discriminator optimization from #292 to work with mixed schemas where only some alternatives have discriminators, rather than requiring all alternatives to have them.
Changes
Test Coverage
Related
Extends #292