Insert missing comma or colon before completion#185
Open
zardoy wants to merge 2 commits intomicrosoft:mainfrom
Open
Insert missing comma or colon before completion#185zardoy wants to merge 2 commits intomicrosoft:mainfrom
zardoy wants to merge 2 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@aeschli I've removed colon insertion, so I do hope the pr will be easier to review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by microsoft/TypeScript#52899
Fixes microsoft/vscode#69545 (but I don't know what to do with *when
"is typed)Though when I just implemented it, I was thinking of why do we need "insert missing colon" behavior: if property has suggestions
:will be added as insert text anyway (but not always e.g. doesn't work withoneOf). But if property doesn't have suggestions, there is no way to trigger such behavior. So I think we should make property completions to always include:as insert case (there are no shorthands in JSON 😃)