Conversation
…mpatibility The serialize-javascript override (^7.0.3) added for the RCE security fix requires Node.js >=20. The project was still targeting Node 18 which doesn't have globalThis.crypto, causing 'ReferenceError: crypto is not defined' during webpack production builds. - Update .nvmrc from 18.20.4 to 20.18.1 - Update engines.node in extension/package.json to >=20.0.0 Fixes #1801
wenytang-ms
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
serialize-javascriptoverride (^7.0.3) added in #1792 for an RCE security fix requires Node.js >=20. The project was still targeting Node 18 (.nvmrcandengines.node), which doesn't haveglobalThis.cryptoavailable by default. This causes aReferenceError: crypto is not definedduringextension:buildProdwebpack builds.Fix
.nvmrcfrom18.20.4to20.18.1engines.nodeinextension/package.jsonfrom^18.20.4to>=20.0.0Node 18 reached EOL in April 2025, so this also aligns the project with a supported LTS version.
Fixes #1801