Bicep support for airgap#792
Merged
paullizer merged 6 commits intomicrosoft:Developmentfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for deploying SimpleChat via Bicep into “custom” / sovereign Azure environments by deriving endpoints from az.environment() and wiring corresponding app settings through to the application’s custom-cloud configuration.
Changes:
- Extends
cloudEnvironmenthandling in Bicep (addspublic/usgovernment/custom, default derived fromaz.environment().name, and legacy value mapping). - Adds custom-environment parameters and conditionally injects custom-cloud app settings into the App Service.
- Tweaks
config.pyAUTHORITY construction to normalize trailing slashes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| docs/explanation/release_notes.md | Documents the new Bicep custom-cloud support and related config change. |
| deployers/bicep/modules/appService.bicep | Adds custom-cloud parameters, uses az.environment() for endpoints/suffixes, and injects custom app settings. |
| deployers/bicep/main.bicep | Expands cloudEnvironment allowed/default behavior and passes custom-cloud params into the app service module. |
| application/single_app/config.py | Normalizes custom identity URL when building AUTHORITY. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
paullizer
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.